Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: slim-docker-github-action #20

Merged
merged 32 commits into from
Aug 3, 2024
Merged

Conversation

luojiyin1987
Copy link
Contributor

@luojiyin1987 luojiyin1987 commented Jul 24, 2024

PR-20 PR-20 PR-20 Powered by Pull Request Badge

Checklist(清单):

  • Labels
  • Assignees
  • Reviewers

Closes #XXXXX

@luojiyin1987
Copy link
Contributor Author

kitabisa/docker-slim-action#7 解决 slim docker 找不到 docker 镜像的问题

@luojiyin1987
Copy link
Contributor Author

appleboy/scp-action#160 解决 scp-action can't open 'build/artifact.tar': Permission 的报错

@luojiyin1987
Copy link
Contributor Author

slimtoolkit/slim#211 还等人修

@luojiyin1987
Copy link
Contributor Author

image
https://github.com/marketplace/actions/docker-slim-github-action
要向上游提 pr 才行。

.github/workflows/deploy-production.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-production.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-production.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
start.sh Outdated Show resolved Hide resolved
@TechQuery TechQuery added the enhancement Some improvements label Jul 28, 2024
@luojiyin1987
Copy link
Contributor Author

放弃使用 distroless 镜像,该镜像没 curl wget,bash,sh,连 apt 一类Linux包管理软件也没 ,只有对应语言的运行环境。攻击面极少,安全性高, 但很难进行调试。 以后优先考虑使用 standalone , nextjs 自己从 node_modules 抽取出来。

不建议使用 slim 相关,逻辑处理非常粗暴,根本补不完。

Dockerfile Outdated Show resolved Hide resolved
.github/workflows/deploy-production.yml Outdated Show resolved Hide resolved
@TechQuery
Copy link
Member

@luojiyin1987 改完 review 后给上游脚手架提个 PR:https://github.com/idea2app/Next-Bootstrap-ts

Dockerfile Outdated Show resolved Hide resolved
@TechQuery TechQuery merged commit 62eb6ce into main Aug 3, 2024
1 check passed
@TechQuery TechQuery deleted the use-docker-slim-github-action branch August 3, 2024 13:49
@luojiyin1987
Copy link
Contributor Author

vercel/next.js#68486
给上游提个 PR, 消除 GitHub action 的警告
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvements
Projects
Development

Successfully merging this pull request may close these issues.

2 participants